Skip to content

Conversation

jzolnowski
Copy link

We can use CodeQL to identify vulnerabilities and errors in our JavaScript code and display the results as code scanning alerts on GitHub

@jzolnowski jzolnowski requested review from Splaktar and gkalpak July 26, 2023 10:45
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gkalpak
Copy link
Contributor

gkalpak commented Jul 26, 2023

Let's put this on hold, until we finalize the proper configuration/approach in xlts-dev/angularjs-webpack-babel#29.

@gkalpak gkalpak marked this pull request as draft July 26, 2023 12:02
@jzolnowski jzolnowski force-pushed the enabling-code-scanning branch from 46457ab to d505612 Compare July 31, 2023 18:48
@jzolnowski jzolnowski marked this pull request as ready for review July 31, 2023 18:49
We can use CodeQL to identify vulnerabilities and errors in our JavaScript code and display the results as code scanning alerts on GitHub
@jzolnowski jzolnowski force-pushed the enabling-code-scanning branch from ef55ef5 to 3216297 Compare July 31, 2023 18:59
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code scanning found an issue: https://github.com/xlts-dev/angularjs-ionic-v1/security/code-scanning/1
It is a false positive, but maybe we could refactor the code to avoid triggering the warning.

Otherwise, the PR lgtm 👍

@jzolnowski
Copy link
Author

@jzolnowski jzolnowski requested a review from gkalpak August 2, 2023 14:56
@jzolnowski jzolnowski force-pushed the enabling-code-scanning branch from c553c97 to 5641097 Compare August 6, 2023 19:54
@jzolnowski jzolnowski force-pushed the enabling-code-scanning branch from 5641097 to 732d4f6 Compare August 10, 2023 15:17
@jzolnowski jzolnowski requested a review from gkalpak August 10, 2023 15:18
@Splaktar Splaktar merged commit 41e7f75 into master Aug 12, 2023
@Splaktar Splaktar deleted the enabling-code-scanning branch August 12, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants